-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPS] Fix abs
for complex types
#125662
[MPS] Fix abs
for complex types
#125662
Conversation
By calling `realPartOfTensor:` if input type is abs
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125662
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit bb3405f with merge base f35fe4e (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good..
@pytorchbot merge -f "MPS tests and lint are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot cherry-pick --onto release/2.3 -c critical |
By calling `realPartOfTensor:` if input type is complex on Sonoma and fall back to `at::view_as_real` trick on Ventura. Split `unary_op` template into `unary_op` and `unary_op_noresize`, which skips resize and empty checks Marked `abs`, `isclose` and `nn.functional.softsign` OpInfo tests as supported by complex types Fixes #125135 Pull Request resolved: #125662 Approved by: https://github.com/kulinseth (cherry picked from commit 0fd1fc1)
Cherry picking #125662The cherry pick PR is at #126096 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
[MPS] Fix `abs` for complex types (#125662) By calling `realPartOfTensor:` if input type is complex on Sonoma and fall back to `at::view_as_real` trick on Ventura. Split `unary_op` template into `unary_op` and `unary_op_noresize`, which skips resize and empty checks Marked `abs`, `isclose` and `nn.functional.softsign` OpInfo tests as supported by complex types Fixes #125135 Pull Request resolved: #125662 Approved by: https://github.com/kulinseth (cherry picked from commit 0fd1fc1) Co-authored-by: Nikita Shulga <[email protected]>
By calling
realPartOfTensor:
if input type is complex on Sonoma and fall back toat::view_as_real
trick on Ventura.Split
unary_op
template intounary_op
andunary_op_noresize
, which skips resize and empty checksMarked
abs
,isclose
andnn.functional.softsign
OpInfo tests as supported by complex typesFixes #125135