Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated test_graph_optims and test_graph_scaling_fused_optimizers to use new OptimizerInfo infrastructure #125127
base: main
Are you sure you want to change the base?
Updated test_graph_optims and test_graph_scaling_fused_optimizers to use new OptimizerInfo infrastructure #125127
Changes from 4 commits
fe29e60
f6cec68
9e86434
8d6abfb
3a86b06
c93214e
2aca95f
501590b
c10432e
8e0945a
1e230e7
c7b33f4
af8653c
35e1b6a
287f741
39d99b5
6d72aff
eac2bd0
b8f1ad0
b75098e
be64baf
79f542b
e901a0a
91264d4
2a6c915
ad331e2
e80cde4
37e6979
d4815a7
a0af2fe
543bba1
b13d6b0
cd6249f
5f92373
8d968d7
236f2fe
83fd6fe
041afac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't a tensor lr okay for the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think tensor lr works, but all the kwargs in the original test used lr=0.1 so I updated the lr here to be 0.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if the bigger lr makes a difference or were you trying to faithfully replicate the configs? If the latter, it is confusing to have the kwarg specific change in the test case and it would be better to not include it unless there was a reason for having LR be bigger than normal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lr tensor for
torch.optim.adam
andtorch.optim.adamw
is not supported when capturable=False and foreach=True, and an error is thrown.