Support Option for Chrome Trace Unit to be in Nanoseconds #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, our internal users have voiced that they prefer the default to be ms. Can you instead introduce a flag or env var to set this? |
mcalman
changed the title
|
@sraikund16 I have updated the PR to keep the default as |
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #923 changed the default chrome trace unit to be
ms. This was done to make readability easier, however, it has the following adverse side effects:Activities that are too close together are incorrectly treated by Chrome Trace-Viewer as nested and moved to separate lines. A discussion on the cause of this can be found here. Setting
"displayTimeUnit": "ns"resolves this issueActivities with very short durations round to durations of
0.000 mswhen usingmsSimple illustration of issue with
"displayTimeUnit": "ms"(ms.pt.trace.json):Issues resolved by switching to
"displayTimeUnit": "ns"(ns.pt.trace.json):