[XPTI] introduce new interface to kineto for PTI-0.11 #1066
Conversation
zejun-chen
changed the title
| XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMHostAlloc_id)); | ||
| XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMSharedAlloc_id)); | ||
| XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMDeviceAlloc_id)); | ||
| } |
There was a problem hiding this comment.
why we still need these UR specific API ids? we should use API set?
There was a problem hiding this comment.
Yes. We will use API set, just apply the previous patch and open a draft PR.
There was a problem hiding this comment.
then, can we make this PR as a draft?
zejun-chen
force-pushed
the
zejun/kineto_for_pti_0.11
branch
from
aebebe7 to
a41d6f7
Compare
zejun-chen
changed the title
Signed-off-by: Chen, Zejun <[email protected]>
zejun-chen
changed the title
|
Hi, @aaronenyeshi Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools. Thank you. |
|
Hi, @aaronenyeshi Could you help review this PR? It is used to update the xpu code in kineto to make it compatible for our new tracing tools. Thank you. |
| @@ -170,6 +170,25 @@ void XpuptiActivityApi::bufferCompleted( | |||
| } | |||
| #endif | |||
|
|
|||
| #if PTI_VERSION_MAJOR > 0 || PTI_VERSION_MINOR > 10 | |||
There was a problem hiding this comment.
Might be useful to use a version schema similar to cuda where they embed the MAJOR, MINOR and PATCH number into one number. If you use OR statements like this it can lead to more complexity if many ifdefs are needed
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Aaron is not actively maintaining Kineto currently. You can reach out to me for future requests! |
Thank you @sraikund16 Really appreciate that |
This PR is used to change the interface for XPTI in kineto to be compatible with the PTI 0.11 release