[ET-VK][testing] Fix on-device tests #16412
Open
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Malibu on-device tests have been failing for a while because the export script is trying to access a manifold asset that seems to no longer exist. Since our team does not own the export process, it is unclear how to resolve the export issue. Therefore, remove the export step from the testing flow. The production model is still tested as part of the flow. Additionally, start running basic test binary and the full ATen operator test suite as part of the android arm64 on device tests for better test coverage. Also add some improvements to the generated operator tests 1. Use seed locking for consistent inputs 2. Make sure generate functions that generate integers cannot generate 0 3. Fix issue with generate_casted_randint function - before, it was producing a tensor with all zeros. Differential Revision: [D89901783](https://our.internmc.facebook.com/intern/diff/D89901783/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16412
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit fcac954 with merge base 0dfda64 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
SS-JIA
pushed a commit
that referenced
this pull request
Dec 30, 2025
The Malibu on-device tests have been failing for a while because the export script is trying to access a manifold asset that seems to no longer exist. Since our team does not own the export process, it is unclear how to resolve the export issue. Therefore, remove the export step from the testing flow. The production model is still tested as part of the flow. Additionally, start running basic test binary and the full ATen operator test suite as part of the android arm64 on device tests for better test coverage. Also add some improvements to the generated operator tests 1. Use seed locking for consistent inputs 2. Make sure generate functions that generate integers cannot generate 0 3. Fix issue with generate_casted_randint function - before, it was producing a tensor with all zeros. Differential Revision: [D89901783](https://our.internmc.facebook.com/intern/diff/D89901783/) ghstack-source-id: 331381719 Pull Request resolved: #16412
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The Malibu on-device tests have been failing for a while because the export script is trying to access a manifold asset that seems to no longer exist.
Since our team does not own the export process, it is unclear how to resolve the export issue. Therefore, remove the export step from the testing flow. The production model is still tested as part of the flow.
Additionally, start running basic test binary and the full ATen operator test suite as part of the android arm64 on device tests for better test coverage.
Also add some improvements to the generated operator tests
Differential Revision: D89901783