Adding Tests for CadenceDefaultQuantizer #16364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16364
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Unrelated FailureAs of commit 5c2c441 with merge base b57b75f ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for CadenceDefaultQuantizer and several other previously untested quantizers, removing them from the EXCLUDED_FROM_ANNOTATION_TESTING set.
Key changes:
- Adds 10 new test cases covering
CadenceDefaultQuantizeroperations (matmul, linear, conv1d, conv2d, bmm, relu) and other quantizers (softmax, layer_norm, add) - Removes 5 quantizers from the exclusion list:
CadenceDefaultQuantizer,CadenceWakeWordQuantizer,CadenceWith16BitConvActivationsQuantizer,CadenceWithLayerNormQuantizer, andCadenceWithSoftmaxQuantizer - Implements 7 new graph builder helper methods to support the new test cases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zonglinpeng
approved these changes
Dec 22, 2025
RahulC7
added a commit
to RahulC7/executorch
that referenced
this pull request
Dec 29, 2025
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88899457
RahulC7
added a commit
to RahulC7/executorch
that referenced
this pull request
Dec 29, 2025
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88899457
RahulC7
force-pushed
the
export-D88899457
branch
from
3bd2b6a to
0fa7586
Compare
RahulC7
added a commit
to RahulC7/executorch
that referenced
this pull request
Dec 29, 2025
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88899457
Summary: Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=384-396 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88895865
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88896712
Summary: Adding test for CadenceWithLayerNormQuantizer. https://www.internalfb.com/code/fbsource/[72237310dfd9016b5f54a44d994c8a7065eda5d1]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=296-306 Reviewed By: hsharma35 Differential Revision: D88898823
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88899457
RahulC7
force-pushed
the
export-D88899457
branch
from
0fa7586 to
5c2c441
Compare
RahulC7
added a commit
to RahulC7/executorch
that referenced
this pull request
Dec 29, 2025
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88899457
RahulC7
added a commit
to RahulC7/executorch
that referenced
this pull request
Dec 29, 2025
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: zonglinpeng, hsharma35 Differential Revision: D88899457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made.
Reviewed By: hsharma35
Differential Revision: D88899457