-
Notifications
You must be signed in to change notification settings - Fork 788
Adding test for CadenceWakeWordQuantizer #16356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16356
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ 1 Pending, 2 Unrelated FailuresAs of commit e3ca0d9 with merge base a1665c5 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary: As title. Differential Revision: D88898933
Summary: As title. Differential Revision: D88898933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds test coverage for four Cadence quantizers that were previously missing tests: CadenceWakeWordQuantizer, CadenceWith16BitConvActivationsQuantizer, CadenceWithLayerNormQuantizer, and CadenceWithSoftmaxQuantizer. The TODO comments for these quantizers are removed from the exclusion list.
Key changes:
- Adds five new test cases to
QUANTIZER_ANNOTATION_TEST_CASEScovering conv1d, conv2d, softmax, layer_norm, and add operations - Implements five new graph builder helper methods for constructing test graphs for each operation type
- Removes four quantizers from
EXCLUDED_FROM_ANNOTATION_TESTINGset
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ( | ||
| "add_A8W8", | ||
| lambda self: self._build_add_graph(), | ||
| CadenceWakeWordQuantizer(), | ||
| torch.ops.aten.add.Tensor, | ||
| qconfig_A8W8.output_activation, | ||
| # For add: both inputs are activations | ||
| [qconfig_A8W8.input_activation, qconfig_A8W8.input_activation], | ||
| ), |
Copilot
AI
Dec 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CadenceWakeWordQuantizer includes both AddPattern and CatPattern (for add and cat operations), but this test only covers the add operation. Consider adding a test case for the cat operation to ensure complete coverage of CadenceWakeWordQuantizer's functionality.
Summary: Pull Request resolved: pytorch#16356 As title. Reviewed By: hsharma35 Differential Revision: D88898933
0db3ba5 to
257c67e
Compare
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
257c67e to
b147389
Compare
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
b147389 to
02025b5
Compare
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: Pull Request resolved: pytorch#16356 As title. Reviewed By: hsharma35 Differential Revision: D88898933
02025b5 to
60a265f
Compare
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| import torch | ||
| from executorch.backends.cadence.aot.graph_builder import GraphBuilder | ||
| from executorch.backends.cadence.aot.graph_builder import GraphBuilder, single_op_builder |
Copilot
AI
Dec 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The single_op_builder import is not used anywhere in the file. All the new graph builder methods use GraphBuilder() directly. This import should be removed to keep the code clean.
| from executorch.backends.cadence.aot.graph_builder import GraphBuilder, single_op_builder | |
| from executorch.backends.cadence.aot.graph_builder import GraphBuilder |
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: Pull Request resolved: pytorch#16356 As title. Reviewed By: hsharma35 Differential Revision: D88898933
60a265f to
16290be
Compare
16290be to
8bc96b3
Compare
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
8bc96b3 to
14e9ce1
Compare
Summary: As title. Reviewed By: hsharma35 Differential Revision: D88898933
Summary: Pull Request resolved: pytorch#16356 As title. Reviewed By: hsharma35 Differential Revision: D88898933
14e9ce1 to
a915386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary: Pull Request resolved: pytorch#16356 As title. Reviewed By: hsharma35 Differential Revision: D88898933
a915386 to
e3ca0d9
Compare
Summary: As title.
Differential Revision: D88898933