Skip to content

Conversation

@RahulC7
Copy link
Contributor

@RahulC7 RahulC7 commented Dec 21, 2025

Summary: As title.

Differential Revision: D88898933

Copilot AI review requested due to automatic review settings December 21, 2025 22:16
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16356

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ 1 Pending, 2 Unrelated Failures

As of commit e3ca0d9 with merge base a1665c5 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 21, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 21, 2025

@RahulC7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88898933.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 21, 2025
Summary:

As title.

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 21, 2025
Summary:

As title.

Differential Revision: D88898933
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds test coverage for four Cadence quantizers that were previously missing tests: CadenceWakeWordQuantizer, CadenceWith16BitConvActivationsQuantizer, CadenceWithLayerNormQuantizer, and CadenceWithSoftmaxQuantizer. The TODO comments for these quantizers are removed from the exclusion list.

Key changes:

  • Adds five new test cases to QUANTIZER_ANNOTATION_TEST_CASES covering conv1d, conv2d, softmax, layer_norm, and add operations
  • Implements five new graph builder helper methods for constructing test graphs for each operation type
  • Removes four quantizers from EXCLUDED_FROM_ANNOTATION_TESTING set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +128 to +139
(
"add_A8W8",
lambda self: self._build_add_graph(),
CadenceWakeWordQuantizer(),
torch.ops.aten.add.Tensor,
qconfig_A8W8.output_activation,
# For add: both inputs are activations
[qconfig_A8W8.input_activation, qconfig_A8W8.input_activation],
),
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CadenceWakeWordQuantizer includes both AddPattern and CatPattern (for add and cat operations), but this test only covers the add operation. Consider adding a test case for the cat operation to ensure complete coverage of CadenceWakeWordQuantizer's functionality.

Copilot uses AI. Check for mistakes.
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 22, 2025
Summary:
Pull Request resolved: pytorch#16356

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
Copilot AI review requested due to automatic review settings December 29, 2025 22:39
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:
Pull Request resolved: pytorch#16356

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


import torch
from executorch.backends.cadence.aot.graph_builder import GraphBuilder
from executorch.backends.cadence.aot.graph_builder import GraphBuilder, single_op_builder
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single_op_builder import is not used anywhere in the file. All the new graph builder methods use GraphBuilder() directly. This import should be removed to keep the code clean.

Suggested change
from executorch.backends.cadence.aot.graph_builder import GraphBuilder, single_op_builder
from executorch.backends.cadence.aot.graph_builder import GraphBuilder

Copilot uses AI. Check for mistakes.
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 29, 2025
Summary:
Pull Request resolved: pytorch#16356

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
Copilot AI review requested due to automatic review settings December 30, 2025 21:25
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 30, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 30, 2025
Summary:

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 30, 2025
Summary:
Pull Request resolved: pytorch#16356

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary:
Pull Request resolved: pytorch#16356

As title.

Reviewed By: hsharma35

Differential Revision: D88898933
@meta-codesync meta-codesync bot merged commit 63f41ea into pytorch:main Dec 30, 2025
139 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants