Skip to content

Arm backend: Keep order of TOSA arguments #12395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Arm backend: Keep order of TOSA arguments #12395

wants to merge 1 commit into from
+4 −2

Conversation

per
Copy link
Collaborator

@per per commented Jul 11, 2025 •
edited by pytorch-bot bot
Loading

Keep None arguments in TOSA arguments creation as well, as they are in Node arguments.

Test plan

Tested through normal CI flow.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

@per
Arm backend: Keep order of TOSA arguments
7ee7857 
Keep None arguments in TOSA arguments creation as well, as they are in
Node arguments.

Change-Id: I0c811f918cc13e944b34bc2dad7f76e839a3be74
@per per requested a review from digantdesai as a code owner July 11, 2025 10:46
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing release notes: none Do not include this in the release notes labels Jul 11, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12395

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 6 Unrelated Failures

As of commit 7ee7857 with merge base fc435fa (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2025
@AdrianLundell
Copy link
Collaborator

Looks like a genuine linting error so let's wait with merging this until @per is back from vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@per @AdrianLundell @digantdesai @facebook-github-bot