[ET-VK] Minor performance improvements for buffer to int8 quantized packing. #12383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking. This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/) [ghstack-poisoned]
This was referenced Jul 11, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12383
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 85803ac with merge base 73c124c ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
Jul 11, 2025
…acking. This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/) ghstack-source-id: 295541275 Pull Request resolved: #12383
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74616519 |
SS-JIA
approved these changes
Jul 11, 2025
…quantized packing." This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74616519 |
trivedivivek
added
the
release notes: vulkan
…quantized packing." This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Jul 11, 2025
…acking. Pull Request resolved: #12383 This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. ghstack-source-id: 295679184 Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/)
|
This pull request was exported from Phabricator. Differential Revision: D74616519 |
…quantized packing." This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/) [ghstack-poisoned]
…quantized packing." This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops. Differential Revision: [D74616519](https://our.internmc.facebook.com/intern/diff/D74616519/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74616519 |
facebook-github-bot
merged commit 947919c
into
gh/trivedivivek/119/base
94 of 99 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Jul 12, 2025
…acking. (#12419) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12383 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/119/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/119/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/114/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/119/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff provides minor performance improvements for buffer to int8 quantized packing in the Vulkan runtime graph ops.
Differential Revision: D74616519