Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Debug lines for cache #585

Open
wants to merge 1 commit into
base: gh/VitalyFedyunin/13/base
Choose a base branch
from

Conversation

VitalyFedyunin
Copy link
Contributor

@VitalyFedyunin VitalyFedyunin commented Jul 11, 2022

Stack from ghstack (oldest at bottom):

import torchtext

train_iter, val_iter, test_iter = \
        torchtext.datasets.IWSLT2017("data/IWSLT2017", language_pair=('en', 'de'))

print(next(iter(train_iter)))

[ghstack-poisoned]
VitalyFedyunin added a commit that referenced this pull request Jul 11, 2022
ghstack-source-id: 06c0b37ab44941f633c33b0aceca869cf7832482
Pull Request resolved: #585
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2022
@VitalyFedyunin VitalyFedyunin changed the title Debug lines for cache [DRAFT] Debug lines for cache Jul 11, 2022
@VitalyFedyunin
Copy link
Contributor Author

Bunch of debug lines to see what is going on with cache keys. We can potentially fix it with additional requirements to file_name_fn and changing contact to some sort of group_by. But it is still error prone and as soon as we find good caching strategy we should redo 1:M or kill it.

@facebook-github-bot
Copy link
Contributor

Hi @VitalyFedyunin!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants