Moco Inplace Update Params #1693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The original code is at https://github.com/facebookresearch/moco/blob/main/moco/builder.py#L63. Can you help submit a upstream PR and add link to |
Contributor
Author
|
That model is last updated in january, don't know if it's really active. |
Contributor
|
@eellison Sorry can you still create a PR? We would like to use it track the patches we've made towards the upstream repo. |
Contributor
Author
xuzhao9
approved these changes
Jun 5, 2023
Contributor
xuzhao9
left a comment
xuzhao9
left a comment
There was a problem hiding this comment.
LGTM, please update the upstream PR link to the code, thanks!
Contributor
|
@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The out of place .data manipulation is slower/more memory, and doesnt work with cudagraphs.
Upstream pr link: facebookresearch/moco#141