Refactoring

[tosemml]

This minor update aims to enhance the code's Pythonic nature and conciseness by employing set intersection.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3576

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @tosemml!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[mthrok]

Hi

Thanks for proposing the change, however, I don't think this is improving the readability, while it can potentially consume a way more memory at set(transcript.split()).

[tosemml]

Thank you for your comment. This change is intended to encourage the use of Python idioms, which is a commonly recommended practice.

[mthrok]

Thank you for your comment. This change is intended to encourage the use of Python idioms, which is a commonly recommended practice.

I am not convinced that just using set makes the code more Pythonic. I'd reorganize the logic of the entire helper function, rather than focusing on one line.