Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stereo to mono transform #3242

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add stereo to mono transform #3242

wants to merge 12 commits into from

Conversation

jjmmchema
Copy link

@jjmmchema jjmmchema commented Apr 5, 2023 •
edited

Implements a transformation for converting multi-channel audio to mono audio. The conversion is done by just taking the average of each channel and then dividing it by the number of channels.

  • Added ToMono class to audio/torchaudio/transforms/ _transforms.py.
  • Added to_mono method in audio/torchaudio/functional/functional.py
  • Indicate dimensions of output tensor.
  • Create tests cases.

Solves Issue: #877

cc @mthrok

@facebook-github-bot
Copy link
Contributor

Hi @jjmmchema!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@faroit faroit mentioned this pull request Apr 7, 2023
Open
jjmmchema
jjmmchema commented Apr 12, 2023
View reviewed changes
test/torchaudio_unittest/transforms/transforms_test.py
wave_channels_first = common_utils.get_whitenoise(n_channels=3)
wave_not_channels_first = common_utils.get_whitenoise(n_channels=3, channels_first=False)

pass
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not implemented

@mthrok mthrok mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok Awaiting requested review from mthrok mthrok will be requested when the pull request is marked ready for review mthrok is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjmmchema @facebook-github-bot