improve type annotations in 'docutils.node.document' #11468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.nodes.document
branch
from
a3efd15 to
da6f310
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
22 tasks
srittau
reviewed
Feb 26, 2024
danieleades
force-pushed
the
docutils.nodes.document
branch
3 times, most recently
from
cfd917b to
d1575df
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.nodes.document
branch
from
9ff4538 to
567bff5
Compare
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Feb 26, 2024
srittau
reviewed
Feb 26, 2024
added 2 commits
February 26, 2024 11:14
danieleades
force-pushed
the
docutils.nodes.document
branch
from
01244ed to
8c031c4
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
- sphinx/addnodes.py: note: In member "set_id" of class "document":
- sphinx/addnodes.py:47:16: error: "set_id" undefined in superclass [misc]
- sphinx/addnodes.py:47:16: note: Error code "misc" not covered by "type: ignore" comment
- sphinx/environment/__init__.py: note: In member "get_and_resolve_doctree" of class "BuildEnvironment":
- sphinx/environment/__init__.py:630:17: error: "document" has no attribute "reporter" [attr-defined]
- sphinx/domains/std/__init__.py:713: error: Unused "type: ignore" comment [unused-ignore]
- sphinx/builders/__init__.py:515: error: Unused "type: ignore" comment [unused-ignore]
- sphinx/builders/__init__.py: note: In member "write_doctree" of class "Builder":
- sphinx/builders/__init__.py:515:9: error: "document" has no attribute "reporter" [attr-defined]
- sphinx/builders/__init__.py:515:9: note: Error code "attr-defined" not covered by "type: ignore" comment
- sphinx/builders/__init__.py:520:9: error: "document" has no attribute "settings" [attr-defined]
- sphinx/builders/__init__.py: note: At top level:
- sphinx/builders/html/__init__.py: note: In member "write_doc" of class "StandaloneHTMLBuilder":
- sphinx/builders/html/__init__.py:650:9: error: "document" has no attribute "settings" [attr-defined]
- sphinx/builders/html/__init__.py: note: At top level:
- sphinx/builders/latex/__init__.py: note: In member "write" of class "LaTeXBuilder":
- sphinx/builders/latex/__init__.py:320:17: error: "document" has no attribute "settings" [attr-defined]
- sphinx/ext/autosummary/__init__.py: note: In function "extract_summary":
- sphinx/ext/autosummary/__init__.py:523:9: error: "document" has no attribute "reporter" [attr-defined]
- sphinx/builders/texinfo.py: note: In member "write" of class "TexinfoBuilder":
- sphinx/builders/texinfo.py:130:17: error: "document" has no attribute "settings" [attr-defined]
- sphinx/builders/manpage.py: note: In member "write" of class "ManualPageBuilder":
- sphinx/builders/manpage.py:97:13: error: "document" has no attribute "settings" [attr-defined]
|
srittau
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is based on the type annotations in https://github.com/tk0miya/docutils-stubs, with a few tweaks