typing tests: remove some unnecessary uses of exec()
#119005
Conversation
AlexWaygood
added
skip issue
skip news
needs backport to 3.12
Lib/test/test_typing.py
Outdated
| exec('async def g(): yield 0', globals(), ns) | ||
| g = ns['g'] | ||
| async def g(): yield 0 | ||
| g = g() |
There was a problem hiding this comment.
In the old code here g was the function, now it's the coroutine returned from the function.
There was a problem hiding this comment.
good catch. Sorry, that was sloppy.
There was a problem hiding this comment.
Although on second thought... doesn't it make more sense to test the coroutine returned from the function here? I think the test might be buggy as-written.
It passes regardless, and this PR wasn't meant to make any semantic changes to the tests, so I'm happy to leave it as-is for now (I pushed 6f25644), but it looks odd to me
There was a problem hiding this comment.
Yeah, it's odd that the passes both with and without the g(). Might be worth looking into whether we can make the test more effective.
There was a problem hiding this comment.
It makes sense that it passes both with and without the g(), because g is only used to check that the [coroutine-function or coroutine] is not an instance of the custom AsyncGenerator subclass here:
cpython/Lib/test/test_typing.py
Lines 7459 to 7460 in 7d7eec5
And of course, it is indeed true that neither a coroutine nor a coroutine function will be an instance of the custom AsyncGenerator subclass
|
Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit a9328e2) Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit a9328e2) Co-authored-by: Alex Waygood <[email protected]>
|
GH-119038 is a backport of this pull request to the 3.13 branch. |
|
GH-119039 is a backport of this pull request to the 3.12 branch. |
) (#119038) (cherry picked from commit a9328e2) Co-authored-by: Alex Waygood <[email protected]>
) (#119039) (cherry picked from commit a9328e2) Co-authored-by: Alex Waygood <[email protected]>
This is a forward-port of python/typing_extensions#219