Make id generation customizable #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branca/folium uses random numbers to generate ids. This has some disadvantages. E.g. in the streamlit-folium plugin they have to replace the random ids with predictable ids for comparison between streamlit runs. Also, in the folium tests, we have to normalize the variable names to compare between expected and actual results. This change in Branca makes it possible to override or customize id generation. This allows client libraries to experiment with new id generation schemes.
ocefpaf
reviewed
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branca/folium uses random numbers to generate ids. This has some disadvantages. E.g. in the streamlit-folium plugin they have to replace the random ids with predictable ids for comparison between streamlit runs. Also, in the folium tests, we have to normalize the variable names to compare between expected and actual results.
This change in Branca makes it possible to override or customize id generation. This allows client libraries to experiment with new id generation schemes.