Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 and 3.12 to Windows and MacOS matrices #3017

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Jun 12, 2024

Part of: #2885

@A5rocks A5rocks mentioned this pull request Jun 12, 2024
17 tasks
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (451393a) to head (b06b544).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3017   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         120      120           
  Lines       17863    17863           
  Branches     3217     3217           
=======================================
  Hits        17798    17798           
  Misses         46       46           
  Partials       19       19           
Files Coverage Δ
src/trio/socket.py 100.00% <ø> (ø)

@A5rocks A5rocks changed the title Add Python 3.11 and 3.12 to Windows CI Add Python 3.11 and 3.12 to Windows and MacOS matrices Jun 12, 2024
@A5rocks A5rocks closed this Jun 12, 2024
@A5rocks A5rocks deleted the standardize-windows-python branch June 12, 2024 14:47
@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 12, 2024

Oh, turns out the github branch rename feature doesn't work. Oh well

@A5rocks A5rocks restored the standardize-windows-python branch June 12, 2024 14:48
@A5rocks A5rocks reopened this Jun 12, 2024
@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 12, 2024

pre-commit.ci autofix

Copy link
Contributor

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, simple enough

@jakkdl
Copy link
Member

jakkdl commented Jun 13, 2024

Huh, did we just forget to add these when adding 3.11/3.12 - or was something broken that now works? Not that it matters, good stuff.

@A5rocks
Copy link
Contributor Author

A5rocks commented Jun 14, 2024

It looks like I added 3.12 at least and while I can't remember exactly, I'm pretty sure I just forgot to add it to Windows/MacOS (because step 1 was adding 3.12-dev which we handle using a PPA, then step 2 (where I forgot) is just removing -dev)

@jakkdl jakkdl enabled auto-merge (squash) June 17, 2024 09:13
@jakkdl jakkdl merged commit 53ff38a into python-trio:master Jun 17, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants