Introduce temporary package version restrictions #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 20 20
Lines 2733 2733
=======================================
Hits 2636 2636
Misses 97 97 ☔ View full report in Codecov by Sentry. |
Closed
peter-doggart
changed the title
|
Bench test fails because install is broken on master, so that can safely be ignored! |
|
Is there an issue with jsonschema==4.19.1? This restriction is causing conflicts in our environment because other tools require 4.19.1. |
|
@brianpaden289 There is an open issue and PR for jsonschema related stuff. It looks like part of the package we use either has been removed or is going to be removed. I just haven't had a chance to look at it yet unfortunately! See #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a temporary restriction on flask, werkzeug and jsonschema packages until we can get everything updated.
It was my intention to temporarily point the pytest-flask installation to a fork that included the 3.0.0 fixes until they are merged upstream. However, the pipeline installs via setuptools and the
pip()function insetup.pystrips out pip git checkout links.