fix(cli): don't require --id when enabling a deploy key
#2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/custom_actions
branch
6 times, most recently
from
7cf32f9
to
00bba45
Compare
|
Hi @nejch Maybe there is a simpler way to do this. As an FYI. I have the idea, as a follow-up, to add a |
JohnVillalovos
force-pushed
the
jlvillal/custom_actions
branch
from
00bba45
to
761889f
Compare
nejch
reviewed
May 20, 2024
There was a problem hiding this comment.
Hi @nejch
Maybe there is a simpler way to do this.
As an FYI. I have the idea, as a follow-up, to add a
helpargument to theCustomActionandregister_custom_actionto enable adding help text to commands if desired
I took a look and looks like the best way to do it. I can't think of another way since custom actions can be really different sometimes 🙇 Just 2 nits from my side as it's a big PR but good to go otherwise!
JohnVillalovos
force-pushed
the
jlvillal/custom_actions
branch
from
761889f
to
1f8a071
Compare
JohnVillalovos
force-pushed
the
jlvillal/custom_actions
branch
3 times, most recently
from
4434a60
to
e08545a
Compare
This makes it more obvious when reading the code what each argument is for.
This adds the `.git-blame-ignore-revs` file which allows ignoring certain commits when doing a `git blame --ignore-revs` Ignore the commit that requires keyword arguments for `register_custom_action()` https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
In some cases we don't want to have `_id_attr` as an argument. Add ability to have it not be added as an argument.
No longer require `--id` when doing: gitlab project-key enable Now only the --project-id and --key-id are required.
nejch
force-pushed
the
jlvillal/custom_actions
branch
from
e08545a
to
343bc3d
Compare
nejch
reviewed
May 22, 2024
nejch
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer require
--idwhen doing:gitlab project-key enable
Now only the --project-id and --key-id are required.