feat(api): add additional parameter to project/group iteration search #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejch
requested changes
Feb 12, 2024
cristianocasella
force-pushed
the
iteration-search-in
branch
from
2194b50
to
faa9d4f
Compare
cristianocasella
changed the title
cristianocasella
force-pushed
the
iteration-search-in
branch
from
faa9d4f
to
0e44648
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
=======================================
Coverage 96.52% 96.53%
=======================================
Files 90 91 +1
Lines 5872 5912 +40
=======================================
+ Hits 5668 5707 +39
- Misses 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Thanks a lot for the rework and documenting this @cristianocasella! Just a few more nits from my side, let me know if you have any questions.
cristianocasella
force-pushed
the
iteration-search-in
branch
2 times, most recently
from
09bec19
to
74345fb
Compare
cristianocasella
force-pushed
the
iteration-search-in
branch
from
74345fb
to
4bc6706
Compare
cristianocasella
force-pushed
the
iteration-search-in
branch
2 times, most recently
from
663e36d
to
fd1f8fb
Compare
nejch
force-pushed
the
iteration-search-in
branch
from
fd1f8fb
to
1c50639
Compare
nejch
reviewed
May 20, 2024
There was a problem hiding this comment.
@cristianocasella I've left one final round of comments/nits that also need an additional import based on your latest comment. Let me know and if you can update this then we can go ahead and merge!
|
Going for a final rebase to include all the last adds |
cristianocasella
force-pushed
the
iteration-search-in
branch
3 times, most recently
from
b3589ef
to
7e8a995
Compare
cristianocasella
force-pushed
the
iteration-search-in
branch
from
7e8a995
to
9a7f3e2
Compare
nejch
reviewed
May 22, 2024
nejch
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2795
Changes
Added "in" parameter to define where te search should be performed in a iteration list.
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: