Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix 404 not found error for saving approval rules #2637

Closed

Conversation

robinson96
Copy link
Contributor

save() was getting id of the merge request instead of id of the approval_rule, setting _id_attr to approval_rule_id addresses this issue.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48726fd) 96.48% compared to head (e6fb635) 96.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2637   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          90       90           
  Lines        5866     5867    +1     
=======================================
+ Hits         5660     5661    +1     
  Misses        206      206           
Flag Coverage Δ
api_func_v4 82.32% <100.00%> (+<0.01%) ⬆️
cli_func_v4 83.58% <100.00%> (+<0.01%) ⬆️
unit 88.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/v4/objects/merge_request_approvals.py 98.76% <100.00%> (+0.01%) ⬆️

@JohnVillalovos JohnVillalovos force-pushed the bugfix/approval_rules_id_fix branch 2 times, most recently from aee8dae to 230a62a Compare August 19, 2023 06:29
@JohnVillalovos
Copy link
Member

I'm going to close this as I think it has already been fixed in #2773 . And the latest published version of python-gitlab has the fix.

If you disagree please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants