cx_freeze support in addition to PyInstaller #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx_freeze support
pukkandan
reviewed
Oct 6, 2021
Comment on lines
+311
to
+314
| if frozen_with == 'cx_freeze': | ||
| return os.path.join(sys.executable, path) | ||
| elif frozen_with == 'PyInstaller': | ||
| return os.path.join(sys._MEIPASS, path) |
There was a problem hiding this comment.
wouldn't it be easier to just do
Suggested change
| if frozen_with == 'cx_freeze': | |
| return os.path.join(sys.executable, path) | |
| elif frozen_with == 'PyInstaller': | |
| return os.path.join(sys._MEIPASS, path) | |
| return os.path.join(getattr(sys, '_MEIPASS', sys.executable), path) |
That way, user can seemlessly switch between the two
|
Is there some benefit from using cx_Freeze over PyInstaller? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built my eel application using cx_freeze instead of PyInstaller, then realized that PyInstaller-specific variables were hardcoded into init.py. In the function _get_real_path, sys.frozen is used by both cx_freeze and PyInstaller. However, sys._MEIPASS is a variable that only PyInstaller uses (to store the current path of the folder). I added support to allow the users to say what their application is frozen with, during the eel.init(), with the variable frozen_with.