📦 Make Git archives reproducible #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago, it was discovered that Git archives having `ref-names: $Format:%D$` in `.git_archival.txt` may change when references existing in the repository change over time [[1]]. This means that downloading an archive for a commit from an immutable URL may start yielding slightly different results. This hurts the ability of downstreams to source projects from Git archive URLs. With that in mind, modern `setuptools-scm` advises against having this entry in the `.git_archival.txt` template [[2]]. And this patch implements said recommendation. [1]: pypa/setuptools-scm#806 [2]: https://setuptools-scm.readthedocs.io/en/latest/usage/#git-archives
hynek
approved these changes
Aug 24, 2024
webknjaz
deleted the
maintenance/setuptools-scm-git-archive-ref-names-reproducibility
branch
hynek
added a commit
to hynek/svcs
that referenced
this pull request
Aug 24, 2024
hynek
added a commit
to pyca/service-identity
that referenced
this pull request
Aug 24, 2024
hynek
added a commit
to hynek/structlog
that referenced
this pull request
Aug 24, 2024
hynek
added a commit
to hynek/doc2dash
that referenced
this pull request
Aug 24, 2024
hynek
added a commit
to hynek/environ-config
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, it was discovered that Git archives having
ref-names: $Format:%D$in.git_archival.txtmay change when references existing in the repository change over time [1]. This means that downloading an archive for a commit from an immutable URL may start yielding slightly different results. This hurts the ability of downstreams to source projects from Git archive URLs.With that in mind, modern
setuptools-scmadvises against having this entry in the.git_archival.txttemplate [2]. And this patch implements said recommendation.