Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run CodSpeed on merge_group events #1305

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Don't run CodSpeed on merge_group events #1305

merged 1 commit into from
Jul 17, 2024

Conversation

hynek
Copy link
Member

@hynek hynek commented Jul 17, 2024

It's not supported.

@hynek
Copy link
Member Author

hynek commented Jul 17, 2024

@webknjaz can you quickly rubber-stamp this, so I can test the merge queue?

ref: https://github.com/python-attrs/attrs/actions/runs/9975150415/job/27564200157#step:5:68

Copy link

codspeed-hq bot commented Jul 17, 2024

CodSpeed Performance Report

Merging #1305 will not alter performance

Comparing cod-merge (0010b45) with main (3df6017)

Summary

✅ 12 untouched benchmarks

@Tinche Tinche self-requested a review July 17, 2024 14:07
@hynek hynek added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 0a09c1a Jul 17, 2024
23 checks passed
@hynek hynek deleted the cod-merge branch July 17, 2024 14:10
@webknjaz
Copy link
Member

@hynek sorry, I was AFK but looks reasonable. Technically, if this was like super desired, the workflow could be migrated to the push event since Merge Queues also push to a temporary branch, so two events are emitted and some services don't really care enough about separating them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants