Remove work-arounds for setting cell_contents #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple assignment to cell_contents works starting from Python 3.7[1]. This is also the minimum supported version of Python according to pyproject.toml. It follows that we don't need complex work-arounds that were needed in the past. Also tested on pypy 3.8. [1] https://bugs.python.org/issue30486
for more information, see https://pre-commit.ci
|
Test failures appear unrelated to my changes. I opened #1202 to try to fix them. |
hynek
approved these changes
Nov 11, 2023
|
@hynek Possibly someone noticed the change mentioned on this page: https://docs.python.org/3.8/whatsnew/changelog.html and assumed it was new in 3.8. However, this is a cumulative changelog, and the change is under "Python 3.7.0 alpha 1" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple assignment to cell_contents works starting from Python 3.7[1]. This is also the minimum supported version of Python according to pyproject.toml. It follows that we don't need complex work-arounds that were needed in the past.
Also tested on pypy 3.8.
[1] https://bugs.python.org/issue30486