Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subclassing of AttrsInstance and Protocol at once #1172

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

hynek
Copy link
Member

@hynek hynek commented Aug 4, 2023

Fixes #1133

@hynek hynek requested a review from euresti August 4, 2023 15:22
Copy link
Contributor

@euresti euresti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

.github/workflows/ci.yml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@hynek hynek merged commit c824bbe into main Aug 6, 2023
20 checks passed
@hynek hynek deleted the attrsinstance-protocol branch August 6, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttrsInstance is only a Protocol in mypy
2 participants