Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SKOptLearner because scikit-optimize is unmaintained #404

Merged
merged 5 commits into from
May 29, 2024

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 7, 2023

Description

Removes the SKOptLearner.

This continuously causes problems (e.g., https://readthedocs.org/projects/adaptive/builds/19128846/ and #333), mostly because https://scikit-optimize.github.io/stable/ is no longer maintained https://github.com/scikit-optimize/scikit-optimize.

It's not compatible with NumPy 1.24 which removed the type aliases (np.float, np.int, etc.).

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@akhmerov
Copy link
Contributor

akhmerov commented Apr 7, 2023

This seems appropriate, but requires a version bump and explaining the removal in the docs. Maybe even raise a more specific import error perhaps?

Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but bump the version as Anton suggests

@basnijholt basnijholt merged commit 05dbdbb into main May 29, 2024
16 of 17 checks passed
@basnijholt basnijholt deleted the remove-skopt-learner branch May 29, 2024 16:38
@basnijholt basnijholt changed the title Remove SKOptLearner Remove SKOptLearner because scikit-optimize is unmaintained May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants