-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication study #260
base: main
Are you sure you want to change the base?
Replication study #260
Conversation
Thanks a lot @jbueltemeier! Two things before I actually start to review:
|
Thank you very much, @pmeier. If you have a good idea to improve this, feel free to push to this branch. |
I'm unable to build the PDF. I think the whole |
This is because the folder with the result images is currently not committed, as there are more than 150 image files in the folder and changes can still take place. So I wanted to integrate it at the end, but if you already need it to build the PDF I can do it now. |
What size of the folder are we talking about? Can we maybe provide the scripts (if they differ from our replication scripts (which the shouldn't)) and only commit the |
Currently the size of the folder is just over 45 MB. |
Could you zip that and send it to me via email? I'll upload it afterwards. |
Done. Could you push the graphics folder minus the images? I'll adjust the archive later so we can extract directly into it. On a side note: please store the images as |
I've cleaned up the branch quite a bit. Compilation should happen through the default command the template provides, i.e. |
@jbueltemeier I've added the workaround from the issue above into the |
Thanks a lot @pmeier for the workaround. As far as I can see, the compilation fails because a few packages and commands (mainly for reference purposes) are missing, which I have added to article.tex. The missing packages are standalone, which could be removed, but also lscape for the tables in the appendix, which I think is necessary to display the tables better. So now I would add this file (article.tex from the template) back or do you see another possibility? |
Can't we put the imports on top of |
No this is not possible, because |
Let me send a fix then. |
@jbueltemeier I've added a That being said, I'm still unable to build the document. The commands that I put in the |
I have added the missing commands. Currently I only get two error messages. The filename of |
I've re-uploaded the images you sent me to https://download.pystiche.org/replication-paper/images.tar.gz |
Here is the first draft for a paper to be published in ReScience . It is based on the ReScience template.
It is currently being edited, feel free to comment on details to improve the paper.
Currently, individual chapters for the results, as well as the information on the hyperparameters used there, need to be attached.