Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h3compat #223

Merged
merged 5 commits into from
Jan 23, 2025
Merged

h3compat #223

merged 5 commits into from
Jan 23, 2025

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Jan 23, 2025

use the correct method for finding average edge length based on h3 version

@knaaptime knaaptime marked this pull request as ready for review January 23, 2025 18:17
@knaaptime knaaptime added bug Something isn't working compat labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.0%. Comparing base (f6fe42d) to head (b583029).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
tobler/util/util.py 0.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #223   +/-   ##
===================================
  Coverage   0.0%   0.0%           
===================================
  Files        13     14    +1     
  Lines       515    534   +19     
===================================
- Misses      515    534   +19     
Files with missing lines Coverage Δ
tobler/util/util.py 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

💪

Co-authored-by: Martin Fleischmann <[email protected]>
@knaaptime
Copy link
Member Author

@jGaboardi any idea why the coverage report keeps showing 0?

@jGaboardi
Copy link
Member

@jGaboardi any idea why the coverage report keeps showing 0?

Seems to be showing 0% of the 4 new lines are covered.

@jGaboardi
Copy link
Member

Do the updated in test_utils.py cover those 4 lines?

@knaaptime
Copy link
Member Author

  1. yea, but 2) if i look at the ubuntu 3.11 tests, it shows 0 across the board?
Screenshot 2025-01-23 at 11 35 06 AM

@jGaboardi
Copy link
Member

yeah... we are clearly using the --cov tobler flag.

@jGaboardi
Copy link
Member

Looking back 2 months, it was also 0% there so this is not a new thing.

@knaaptime knaaptime merged commit 5aeb4d7 into pysal:main Jan 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants