-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] JOSS paper revisions work #200
Conversation
@xf37, I can add the current edits from the google doc into the |
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
=======================================
+ Coverage 65.1% 65.3% +0.2%
=======================================
Files 23 23
Lines 2458 2461 +3
Branches 494 494
=======================================
+ Hits 1600 1607 +7
+ Misses 786 777 -9
- Partials 72 77 +5
|
Thanks @jGaboardi, I am more than happy to be a co-author for this paper. Here is my ORCID and affiliation: ORCID: https://orcid.org/0000-0002-5549-9457 |
ORCID: https://orcid.org/0000-0002-4758-1776 |
HI sorry ORCID: https://orcid.org/0000-0003-0274-599X and affil: University of Bristol |
@jGaboardi I went through the paper again in the google doc and edited a few places (such as the names of our models!). It will be great if we can also update Figure 2. See my comments there. |
@qszhao I will try to get everyone's edits from the google doc to the |
I plan to go ahead with a release, which will be the baseline for our submission, this weekend after implementing the text update in the PR. If there are any detractors, speak now. |
Tie in with #203 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting to address #196.
This PR starts the updates to the JOSS paper that incorporates the locate module.