Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support geopandas objects in distance statistics #145

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

martinfleis
Copy link
Member

A simple change that allows us to pass geopandas objects directly onto Ripley's functions without a need of extracting the underlying array of coordinates.

This is a part of #135 that does not need me to learn the dispatch thingy :)

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.9%. Comparing base (4ecafc6) to head (ef72770).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #145     +/-   ##
=======================================
+ Coverage   69.7%   69.9%   +0.2%     
=======================================
  Files         12      12             
  Lines       1775    1785     +10     
=======================================
+ Hits        1237    1247     +10     
  Misses       538     538             
Files Coverage Δ
pointpats/distance_statistics.py 83.0% <100.0%> (+0.8%) ⬆️

Copy link
Member

@knaaptime knaaptime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that was easy. neat.

@martinfleis martinfleis merged commit 8c20108 into pysal:main Aug 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants