Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geographs #563

Merged
merged 230 commits into from
Sep 7, 2023
Merged

Geographs #563

merged 230 commits into from
Sep 7, 2023

Conversation

ljwolf
Copy link
Member

@ljwolf ljwolf commented Sep 7, 2023

This merges the geography branch into the main branch, so that we can continue working and prepare for a point release with the geography functionality.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #563 (5f3fdb3) into main (64d122d) will increase coverage by 1.7%.
The diff coverage is 92.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #563     +/-   ##
=======================================
+ Coverage   79.9%   81.6%   +1.7%     
=======================================
  Files        113     127     +14     
  Lines      13151   14860   +1709     
=======================================
+ Hits       10507   12119   +1612     
- Misses      2644    2741     +97     
Files Changed Coverage Δ
libpysal/graph/_set_ops.py 43.5% <43.5%> (ø)
libpysal/graph/_kernel.py 72.2% <72.2%> (ø)
libpysal/graph/_parquet.py 84.0% <84.0%> (ø)
libpysal/graph/tests/test_triangulation.py 84.4% <84.4%> (ø)
libpysal/graph/_utils.py 91.1% <91.1%> (ø)
libpysal/graph/base.py 95.7% <95.7%> (ø)
libpysal/graph/_triangulation.py 98.0% <98.0%> (ø)
libpysal/graph/_contiguity.py 98.7% <98.7%> (ø)
libpysal/graph/tests/test_utils.py 98.8% <98.8%> (ø)
libpysal/graph/_spatial_lag.py 100.0% <100.0%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@martinfleis
Copy link
Member

Do you mind if I remove Roadmap.md and w_workbench.ipynb to keep the source of main clean?

@jGaboardi
Copy link
Member

Do you mind if I remove Roadmap.md and w_workbench.ipynb to keep the source of main clean?

We should keep the Roadmap at least stored in a Wiki or something, right?

@jGaboardi jGaboardi added the graph label Sep 7, 2023
@martinfleis
Copy link
Member

Do you mind if I remove Roadmap.md and w_workbench.ipynb to keep the source of main clean?

We should keep the Roadmap at least stored in a Wiki or something, right?

We have #562 now. Roadmap.md is heavily outdated anyway.

@ljwolf ljwolf merged commit c2fe1e4 into main Sep 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants