Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move conftest #96

Merged
merged 2 commits into from
Jan 29, 2025
Merged

move conftest #96

merged 2 commits into from
Jan 29, 2025

Conversation

martinfleis
Copy link
Member

conftest needs to be within the package to be shipped along with the tests. Otherwise it breaks the reverse dependency testing in lib.

@martinfleis martinfleis requested a review from sjsrey January 27, 2025 12:52
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.4%. Comparing base (0cfdecf) to head (790dcd6).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #96      +/-   ##
========================================
+ Coverage   66.7%   93.4%   +26.7%     
========================================
  Files          9       9              
  Lines        561     561              
========================================
+ Hits         374     524     +150     
+ Misses       187      37     -150     

see 1 file with indirect coverage changes

@martinfleis
Copy link
Member Author

Note that to fix the reverse dep check, this requires to be included in a release. Reverse deps are tested against stable, not dev.

@sjsrey
Copy link
Member

sjsrey commented Jan 27, 2025

Thanks for catching this. I will merge and cut a release before meta ships.

@sjsrey sjsrey merged commit eb998bf into pysal:main Jan 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants