Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_chat_history: add min_id & max_id parameters #1366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkjdid
Copy link

@rkjdid rkjdid commented Nov 20, 2023

I'm switching lib from telethon because poor perfs, good news is that I retreive messages instantly now, was not the case with telethon.

But the way my code works I keep track of the last (most recent) message retreived from history - this is conveniently handled via min_id param to Telegram's API, which is not passed down to base request in pyrogram. (offset_id does the work in reverse, probably acting similar to max_id, not sure if there is a difference)

So here is my small contribution. I've also added max_id along the way but reflecting on what I just said maybe it would add confusion.

This does the job for me, could help others. Could also be included in get_messages and search_messages perhaps, for now I only use get_chat_history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant