Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test expectation via public API. #75

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Test expectation via public API. #75

merged 1 commit into from
Nov 29, 2019

Conversation

null-a
Copy link
Collaborator

@null-a null-a commented Nov 26, 2019 •
edited
Loading

This is a minor change that replaces test_expected_response_codegen with a new test that's similar to the recently added test_mu_correctness. I think this is an improvement because it actually exercises fit.fitted(what='expectation'). I think the cases are a little easier to read this way too.

(Related: #15)

@null-a null-a requested a review from neerajprad November 26, 2019 14:43
@neerajprad neerajprad merged commit d72cc47 into master Nov 29, 2019
@null-a null-a deleted the improve_expectation_test branch November 29, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neerajprad neerajprad neerajprad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@null-a @neerajprad