Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility kludge to work with older packaging #1217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix compatibility kludge to work with older packaging #1217

wants to merge 4 commits into from

Conversation

dnicolodi
Copy link
Contributor

Fixes #1216.

@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch 2 times, most recently from 5c7dcb9 to 3680db0 Compare January 22, 2025 10:09
@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch from 3680db0 to 3ea3455 Compare January 22, 2025 10:46
@dnicolodi
Copy link
Contributor Author

dnicolodi commented Jan 22, 2025 •
edited
Loading

The issue was not caught by the tests because they run with a more recent packaging. I can extend the CI matrix to cover a couple of versions of packaging but I would like to know if the maintainers think that this is a good idea before putting in the work...

sigmavirus24
sigmavirus24 requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage for this

@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch 4 times, most recently from 10bc88d to 71addd7 Compare January 22, 2025 13:45
@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch from 71addd7 to fc6d0ce Compare January 22, 2025 13:51
@dnicolodi
Copy link
Contributor Author

@sigmavirus24 done. My tox-fu is very limited, thus I am not sure the way I am adding the versioned dependency is the best one. Let me know if you think there is a better way.

@dnicolodi
Copy link
Contributor Author

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dnicolodi @sigmavirus24