Add pylock #900
Open
Add pylock #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
commented
May 6, 2025
| url: str | None # = None | ||
| path: str | None # = None | ||
| size: int | None # = None | ||
| upload_time: datetime | None # = None |
There was a problem hiding this comment.
In the spec, the upload_time field is not at the same position for archive and sdist / wheel.
Is that intended or something we want to tweak here and/or in the spec?
There was a problem hiding this comment.
That was intended as the idea (and expected value) comes from the index API and I don't think archives are supported there.
There was a problem hiding this comment.
But if people have uses for an upload time for archives then I suspect making it a 1.1 change wouldn't be controversial.
There was a problem hiding this comment.
Note my remark was only about the ordering of the fields, not about the presence of upload_time in archive.
2 tasks
My idea was to have from_dict independent of the class to cope for future evolution, but if a new version of the standard can't be implemented as a subclass of Pylock, return type of from_dict would change, so it would be a breaking change. If/when a new version of the spec arrive, it will still be time to design the API evolution, depending of the actual changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the proposal for
pylock.tomlsupport.from_dictfunction to validate and create aPylockinstance from a toml dict (obtained fromtomllib.load)Pylock.to_dictmethod to convert to a spec-compliant toml dict (assuming types were respected when populating the dataclass), preserving the recommended field orderingis_valid_pylock_pathto validate pylock file namesDocumentation is still TODO.
closes #898