-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add PEP 751 #1848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add PEP 751 #1848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have a couple comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the reference changes.
Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
Co-authored-by: Filipe Laíns 🇵🇸 <[email protected]>
@FFY00 thanks for all of the references! I had to insert blank lines and then I went through and replaced every place I could think of with a reference. 😁 |
It's weird that the linkcheck job gets stuck for 48 minutes while on |
Along the way, ignore a troublesome URL that's slowing down link checking significantly.
@FFY00 I took your reformat idea to try and keep the HTML page from having so much horizontal scroll, but I also indenting subtables for ease of reading. |
@webknjaz looks like adding that URL to the ignore list did the trick to make CI fast again! PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brettcannon. Looking good.
📚 Documentation preview 📚: https://python-packaging-user-guide--1848.org.readthedocs.build/en/1848/