Skip to content

Add PEP 751 #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add PEP 751 #1848

wants to merge 9 commits into from

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Apr 14, 2025

@webknjaz webknjaz requested a review from a team April 15, 2025 01:18
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a couple comments.

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the reference changes.

@brettcannon
Copy link
Member Author

@FFY00 thanks for all of the references! I had to insert blank lines and then I went through and replaced every place I could think of with a reference. 😁

@webknjaz
Copy link
Member

It's weird that the linkcheck job gets stuck for 48 minutes while on main it takes like a minute...

Along the way, ignore a troublesome URL that's slowing down link checking significantly.
@brettcannon
Copy link
Member Author

@FFY00 I took your reformat idea to try and keep the HTML page from having so much horizontal scroll, but I also indenting subtables for ease of reading.

@brettcannon
Copy link
Member Author

@webknjaz looks like adding that URL to the ignore list did the trick to make CI fast again! PTAL.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brettcannon. Looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants