Add commands to hatch cli from plugins #805
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyfuture
reviewed
Apr 6, 2023
| shutil.copytree(importlib_resources.files(__package__) / "cli-plugin", project_dir) | ||
|
|
||
| with project_dir.as_cwd(): | ||
| result1 = hatch("new", "--init") |
There was a problem hiding this comment.
Suggested change
| result1 = hatch("new", "--init") | |
| hatch("new", "--init") |
There was a problem hiding this comment.
This is still in draft, that part is anyway not working (cf: #805 (comment)) -> forgot to add a TODO on top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #798
pluggySmall clarification concerning the implementation, it might feel strange that I did not use the normal
PluginManager(i.e.: withinhatch.cli.Application) but instead directly used nativelypluggy. This is because a command created from an external plugin must be added to thehatch(which is of typeclick.Group) before it can be executed. (Otherwise, the command won't be able to be resolved -> it's basically the chicken and egg problem)