Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hatch-pyz to known third-party builder plugins #1651

Closed
wants to merge 4 commits into from
Closed

Add hatch-pyz to known third-party builder plugins #1651

wants to merge 4 commits into from

Conversation

djcopley
Copy link
Contributor

A hatch build target for python zip applications

ofek
ofek requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please ensure alphabetical ordering?

@djcopley
Copy link
Contributor Author

Absolutely! The files are currently consistently ordered in the following manor:

  1. __main__.py
  2. Dependencies (alphabetically sorted)
  3. Project files (alphabetically sorted)

I'm guessing you're asking that all files are alphabetically sorted at the same priority level, instead of sorted in blocks?

@ofek
Copy link
Collaborator

ofek commented Jul 31, 2024

image

@djcopley
Copy link
Contributor Author

djcopley commented Jul 31, 2024 •
edited
Loading

Ah gotcha. Updated.

@djcopley djcopley requested a review from ofek July 31, 2024 19:59
@djcopley djcopley closed this Oct 31, 2024
@djcopley djcopley deleted the hatch-pyz branch October 31, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek Awaiting requested review from ofek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djcopley @ofek