Apply a few ruff/refurb rules (FURB) #1480
Open
+12
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ def safe_walk(path: str) -> Iterable[tuple[str, list[str], list[str]]]: | |||
| stat = os.stat(root) | |||
| identifier = stat.st_dev, stat.st_ino | |||
| if identifier in seen: | |||
| del dirs[:] | |||
| dirs.clear() | |||
There was a problem hiding this comment.
You might find this one questionable, since del list[:] is a widely used Python idiom. But then list.clear() is explicit, even for those with less exposure to Python.
DimitriPapadopoulos
force-pushed
the
refurb
branch
8 times, most recently
from
9dc16ff
to
09a0a1f
Compare
I have fixed the few cases which I think result in more readable code.
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
09a0a1f
to
9a5d83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the few cases which I think result in more readable code.
Would it be OK to add these rules?