fix: avoid races in filesystem ops #2287
Open
+3
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
exist_ok
andmissing_ok
in pathlib operations where we can.I didn't do an exhaustive audit of pathlib usage, but I did look at places where the code was using
path.exists()
. There's still a couple of places with this pattern:I don't think there's an elegant solution that will work across Python versions currently, although in 3.13 I think one can do:
Because: "Changed in version 3.13:
rmtree()
now ignoresFileNotFoundError
exceptions for all but the top-level path." (https://docs.python.org/3.13/library/shutil.html#shutil.rmtree)Fixes #2279.