-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul of metadata to move away from pandas #415
Draft
sjvenditto
wants to merge
21
commits into
dev
Choose a base branch
from
faster_metadata
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas DataFrames, while versatile, add a lot of overhead to object initialization with metadata, even when metadata is an empty DataFrame. Since slicing an existing object can often return a new object, this overhead is compounded each time an object is sliced.
In this PR, I've replaced the datatype of the private
_metadata
to a custom dictionary, where it previously was a pandas DataFrame. This custom dictionary includes minimal methods used by_metadata
's DataFrame counterpart -- e.g..loc
,.iloc
,.columns
,.index
-- but is proving to be more lightweight. Rudimentary benchmarking suggests that, with the dictionary metadata, slicingIntervalSet
andTsdFrame
objects is 4-8X faster for objects with metadata and 2-3X faster for objects without metadata (i.e. empty metadata), when compared to objects with DataFrame metadata. (This speed up is not seen forTsGroup
objects, which has a much slower initialization that the other objects, where metadata initialization is not the primary source of overhead)On the user side of things, metadata will behave exactly the same as it did previously, where
obj.metadata
still returns a DataFrame.