Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipython tab autocompletions for TsdFrame columns #406

Closed
wants to merge 1 commit into from

Conversation

eschombu
Copy link
Contributor

Using this stackoverflow answer, we can get the behavior shown in the screenshot.
Screenshot 2025-01-30 at 1 00 55 PM

@eschombu eschombu requested a review from gviejo as a code owner January 30, 2025 18:04
@eschombu eschombu changed the base branch from main to dev January 30, 2025 19:17
@gviejo
Copy link
Contributor

gviejo commented Jan 31, 2025

I am curious what it does when you don't have strings for columns

@gviejo
Copy link
Contributor

gviejo commented Jan 31, 2025

Ok I am not sure it's a good idea if you don't have labeled columns. It does this for integers but it's a bit misleading because this is numpy behavior now

image

@eschombu
Copy link
Contributor Author

I guess I haven't used pynapple enough to have realized the various kinds of objects that will use the TsdFrame.getitem method, and keys used by that. I could definitely add some sort of check to only show columns labels if they're all strings. Or we can drop the idea.

@gviejo
Copy link
Contributor

gviejo commented Jan 31, 2025

I would drop it because I would like eventually to force the behavior of slicing TsdFrame with the .loc when there are labelled columns. That would disambiguiate many things.

@eschombu eschombu closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants