Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix - tsd initialization #396

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Hotfix - tsd initialization #396

merged 5 commits into from
Jan 17, 2025

Conversation

BalzaniEdoardo
Copy link
Collaborator

Some of the methods of Tsd were not overwriting the epochs when ep was provided (like bin_average. or interpolate).
Fix the issue with this PR to fix the behavior of these operation. Added tests.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pynapple/core/time_series.py 89.43% <100.00%> (ø)

@BalzaniEdoardo
Copy link
Collaborator Author

Compare the funtion I just fixed to this:

https://github.com/pynapple-org/pynapple/blob/d62403503eb0a27cf9a6c535fa50e3102cfbbce3/pynapple/core/time_series.py

which show how they were before the introduction of _initialize_tsd_output

@gviejo gviejo changed the base branch from main to dev January 17, 2025 10:53
@gviejo gviejo merged commit 68dcc62 into dev Jan 17, 2025
15 checks passed
@gviejo gviejo deleted the check_bin_average branch January 17, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants