-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing build_tensor and warp_tensor in warping.py #388
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
I have some thoughts about the naming conventions used here:
My thought is to have a central function
and that way both ways of building a tensor can be accessed in a centralized location. In this way, the current
What do you think about this? |
Here is the proposed behavior :
Simple trial-based tensor :
Time-warped trial based tensor :
Both functions works for any time series.