Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a bug in the CoreConnectedGridPlanWidget when selecting the bound mode #396

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Jan 26, 2025

Not sure if this is the best fix but...

To reproduce the current bug:

from pymmcore_plus import CMMCorePlus
from pymmcore_widgets.mda._core_grid import CoreConnectedGridPlanWidget
mmc = CMMCorePlus()
mmc.loadSystemConfiguration()
g = CoreConnectedGridPlanWidget()
g.show()
g.setMode("bounds")

Now manually modify any of the top/bottom/left/right values and then run:

g.value()

In the current version the top/bottom/left/right values are always 0.

I'm not sure how to test this because if we setup the widget top/bottom/left/right values with the setValue() method and then we call the value() the top/bottom/left/right values are correct. The difference is that graphically on the widget we do not see the top/bottom/left/right values added through the setValue().

Screen.Recording.2025-01-26.at.1.37.55.PM.mov

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.65%. Comparing base (f104046) to head (4796eb0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/mda/_xy_bounds.py 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   90.74%   90.65%   -0.09%     
==========================================
  Files          85       85              
  Lines        9374     9360      -14     
==========================================
- Hits         8506     8485      -21     
- Misses        868      875       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 enabled auto-merge (squash) January 27, 2025 20:34
@tlambert03 tlambert03 merged commit 9db494b into pymmcore-plus:main Jan 27, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants