Simplify the Function class

[HangenYuu]

Description

Simplify the function class in pytensor.

• Remove the output_subset kwargs at call time of class Function as no one is using it.
• Check and Remove unused pytensor.function() parameters (use default value in codes instead)
• Expose trust_input as a parameter.

Related Issue

• Closes Simplify Function class #552
• Related to #

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

[HangenYuu]

These are the current parameters to pytensor.function():

• inputs: Iterable[Variable]
• outputs: Variable | Iterable[Variable] | dict[str, Variable] | None = None
• mode: str | Mode | None = None
• updates: Iterable[tuple[Variable, Variable]] | dict[Variable, Variable] | None = None
• givens: Iterable[tuple[Variable, Variable]] | dict[Variable, Variable] | None = None
• no_default_updates: bool = False
• accept_inplace: bool = False
• name: str | None = None
• rebuild_strict: bool = True
• allow_input_downcast: bool | None = None
• profile: bool | ProfileStats | None = None
• on_unused_input: str | None = None

The ones I propose to remove and use a default value are

• accept_inplace: False No inplace ops by default.
• rebuild_strict: True by default.
• allow_input_downcast: None by default.
• profile: None by default.
• on_unused_input: None by default.

I also want to ask about givens and no_default_updates since I have never used them before (givens seem unremoveable though).

[ricardoV94]

The ones I propose to remove and use a default value are

Those are all still useful, unfortunately.

There's a getattr in call that we can remove according to the comment about being there for old pickles

[HangenYuu]

Some things we could probably remove because nobody uses them:

1. Default values for function argument

Oh wait, then what did you mean here in #552 🫤

[ricardoV94]

Some things we could probably remove because nobody uses them:

1. Default values for function argument

Oh wait, then what did you mean here in #552 🫤

https://pytensor.readthedocs.io/en/latest/library/compile/io.html#value-initial-and-default-values

[HangenYuu]

Some things we could probably remove because nobody uses them:

1. Default values for function argument

Oh wait, then what did you mean here in #552 🫤

https://pytensor.readthedocs.io/en/latest/library/compile/io.html#value-initial-and-default-values

Oh so you meant to remove value parameter from the pytensor.compile.io.In?

[HangenYuu]

Also, I realized 2 things that output_keys will create output_subset behind the scene. So removing output_subset means that I also need to remove output_keys, together with the tests testing for them e.g., test_partial_function_with_output_keys. Is this okay?

[ricardoV94]

Also, I realized 2 things that output_keys will create output_subset behind the scene. So removing output_subset means that I also need to remove output_keys, together with the tests testing for them e.g., test_partial_function_with_output_keys. Is this okay?

Sounds okay