Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites for triangular matrices #1131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tanish1729
Copy link
Contributor

@tanish1729 tanish1729 commented Dec 17, 2024

Description

Currently, we check for triangular matrices by seeing whether it is an output of a cholesky Op or not. It can then be used to add optimized rewrites for the triangular matrices.

  1. det(triangular) -> product of diagonal elements
  2. inv(triangular) -> use solve triangular

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1131.org.readthedocs.build/en/1131/

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (231a977) to head (0c43019).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   82.10%   82.13%   +0.02%     
==========================================
  Files         185      185              
  Lines       48130    48158      +28     
  Branches     8669     8673       +4     
==========================================
+ Hits        39519    39555      +36     
+ Misses       6444     6438       -6     
+ Partials     2167     2165       -2     
Files with missing lines Coverage Δ
pytensor/tensor/rewriting/linalg.py 93.25% <100.00%> (+0.48%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant