Improve creating an op documentation page #1086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
ricardoV94
commented
Nov 13, 2024
| @@ -165,35 +151,6 @@ or :meth:`Op.make_thunk`. | |||
| :meth:`COp.c_code` and other related ``c_**`` methods. Note that an | |||
| :class:`Op` can provide both Python and C implementations. | |||
|
|
|||
| :meth:`Op.make_thunk` method is another alternative to :meth:`Op.perform`. | |||
There was a problem hiding this comment.
This is outdated, and tbh I don't think it's necessary for 99.9999% of the people reading this page
ricardoV94
force-pushed
the
creating_an_op
branch
from
2f1a456
to
3a77d6b
Compare
ricardoV94
force-pushed
the
creating_an_op
branch
2 times, most recently
from
c794f26
to
7e407f9
Compare
Changes: 1. Remove references to c-code which apply to `COp` but not `Op` 2. Fix failing doctests 3. Improve explanation of `make_node` 4. Emphasize distinction between itypes/otypes and make-node 5. Show `L_op` instead of `grad` 6. Show how to test `L_op` and `infer_shape` implementation 7. Simplify explanation of `__props__` and illustrate in example. 8. Introduce more complex multi-output Op to drive these details home 9. Remove old references to numba/ random variable Ops
ricardoV94
force-pushed
the
creating_an_op
branch
from
7e407f9
to
d37103d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for list of changes.
The changes are based on feedback from helping other devs and users
Tagging @OriolAbril because I'm 100% sure I messed up some sphinx stuff (sorry)
📚 Documentation preview 📚: https://pytensor--1086.org.readthedocs.build/en/1086/